ResolvableSelector supports parse addr and extractor options #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
liuzengh
added a commit
to trpc-group/cla-database
that referenced
this pull request
May 16, 2024
liuzengh
reviewed
May 16, 2024
service_name_extractor.go
Outdated
There was a problem hiding this comment.
Confirm whether the changes in this file have been refactored？The code before the change seems to be more readable than the code after the change.
liuzengh
changed the title
liuzengh
approved these changes
May 16, 2024
Merged
liuzengh
added a commit
that referenced
this pull request
May 16, 2024
* update badges (#4) * update badges * fix typo * Update README.md (#5) * Update README.zh_CN.md (#6) * add issue template (#7) * ResolvableSelector supports parse addr and extractor options (#8) * all: ResolvableSelector supports parse addr and extractor options * all: revert service_name_extractor change --------- Co-authored-by: MengYinlei <43751910+YoungFr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow for more precise control over the
ResolvableSelectorfromthe outside, we have added the
ParseAddrandExtractoroptions to it.